Conversation
viveknair
changed the title
viveknair
force-pushed
the
vivek/gt-1799-implement-concurrent-execution-in-eval_dataset-tests
branch
from
ce152bb to
6bc2a05
Compare
viveknair
changed the title
Merged
viveknair
pushed a commit
that referenced
this pull request
Jul 8, 2025
* feat: Add max concurrency limit, create shared GentraceWarning abstraction (#335) * feat: Add concurrency management for eval_dataset * fix: Update max_concurrency to 30 in eval_dataset_simple file * feat: Add async concurrency control for interaction functions * chore: refactor warning display for better readability * chore: Add line break before warning panel * release: 1.0.0-alpha.12 --------- Co-authored-by: Vivek Nair <vivek@gentrace.ai> Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Adds max concurrency control for parallel execution in eval_dataset tests
Summary
This PR introduces concurrency limiting functionality to control the number of parallel tasks that can run simultaneously during dataset evaluation. It adds a new
max_concurrencyparameter and implements a thread pool singleton for managing both async and sync task execution.Key Changes
max_concurrencyparameter toeval_dataset()functionconcurrency.pymodule withThreadPoolSingletonclassImpact
eval_datasetfunction signature modified to accept concurrency limitmax_concurrency=1Testing Considerations
max_concurrencyvalues