cache_lifetime can be null to let the underlying cache handle the lifetime #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think you are correct. @samybasset what do you think? |
norkunas
requested changes
Jul 10, 2019
Member
norkunas
left a comment
norkunas
left a comment
There was a problem hiding this comment.
Looks good, we should merge this after requested changes.
| /** | ||
| * @test | ||
| */ | ||
| public function cache_lifetime_can_be_null_in_order_to_let_this_detail_handle_the_cache_service() |
Member
There was a problem hiding this comment.
Test name should be consistent with others :)
| $this->assertInstanceOf(CachePlugin::class, $plugins[0]); | ||
| } | ||
|
|
||
| /** |
Author
|
Hm, i already forgot about this PR, sorry |
Member
|
No problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CachePlugin was always able to have a lifetime = null, so this should also be used. I'm not completely sure, whether this is a bug, which should be fixed in other branches, or whether it is a new feature.
Use-Case is simple as that: I want to configure my cache completely independent of this bundle and only let the bundle know the service id.