Fix exception type #514
Fix exception type #514
Conversation
Provides use Ivory adapters for executing the requests. Executing such requests may results in failures, which are currently thrown as `Ivory\HttpAdapter\HttpAdapterException`. As those exceptions are not catched, the user may get one of those issues instead of the expected `Geocoder\Exception\Exception`. - Provide a helper method in `AbstractHttpProvider` to safely execute the query via the adpater and retrieve the content - Add tests for each concerned adapters Closes geocoder-php#497
|
I like this PR and I'll be happy to merge it... But.. We do not use Ivory anymore. We use HTTPlug. Can you rebase and update this PR? |
|
@Nyholm will try next week |
|
why its failing fix it i need to use it |
|
@dsslimshaddy please stop, you are being incredibly rude by behaving like that. If you need it urgently, fix it yourself and @Nyholm will gladly merge it ASAP. If you're not ready to do so fix it in your vendors or in a fork and be patient. |
|
@Nyholm I'm a bit overwhelmed at work this month, so I probably won't be able to look at it before mid-February :/ |
|
@theofidry don't forget this one please :) |
|
@danijelk you can also take over :) I'm a bit too busy with work, Alice and Humbug lately :/ |
|
Have a look at #617. With that PR it will be easier to implement this feature. |
|
Closed by #617 |
4 participants
Provides use Ivory adapters for executing the requests. Executing such requests may results in failures, which are currently thrown as
Ivory\HttpAdapter\HttpAdapterException. As those exceptions are not catched, the user may get one of those issues instead of the expectedGeocoder\Exception\Exception.AbstractHttpProviderto safely execute the query via the adpater and retrieve the contentNote: I'm not a big fan of protected methods, but in this case this proves to be the most effective way to deal with this issue.
Closes #497
@willdurand I'm not sure how you want to handle this patch, it could be backported to the previous
3.xreleases but I know this can be a bit of a pain as well.