Feature/update googlemaps reverse url #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add REVERSE_ENDPOINT_URL * Update reverse method #550
Member
|
Awesome @arubacao. Thank you. I like that you added an issue before and then wrote proper tests. Good job! |
norkunas
pushed a commit
to norkunas/Geocoder
that referenced
this pull request
Dec 22, 2016
* * Rename ENDPOINT_URL to GEOCODE_ENDPOINT_URL * Add REVERSE_ENDPOINT_URL * Update reverse method geocoder-php#550 * Update tests geocoder-php#550 * Add cached response
Contributor
Author
|
No need to thank me @Nyholm! Great to see that things are going forward after your interfaces PR! Keep up the great work |
Member
|
Thank you. I've created a milestone for 4.0. My plan is to have a release candidate in January. |
Contributor
Author
|
Sorry for the late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #550