Update unittest passage #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use phpunit from vendor to prevent issues don't suggest to rename `phpunit.xml.dist` https://phpunit.de/manual/current/en/organizing-tests.html#organizing-tests.xml-configuration If there is no `phpunit.xml` then phpunit will use `phpunit.xml.dist` , so whats the point in renaming it?
Nyholm
requested changes
Dec 22, 2016
|
|
||
| You'll obtain some _skipped_ unit tests due to the need of API keys. | ||
|
|
||
| Rename the `phpunit.xml.dist` file to `phpunit.xml`, then uncomment the |
Member
There was a problem hiding this comment.
One should rename the phpunit.xml.dist file to phpunit.xml to avoid accidentally checking in your API keys.
Contributor
Author
There was a problem hiding this comment.
Makes sense, didn't see that in the gitignore. Elegant way to ensure security
README.md
Outdated
|
|
||
| ``` | ||
| $ phpunit | ||
| $ ./vendor/bin/phpunit |
Member
There was a problem hiding this comment.
Even better: We should use a composer script so we can run:
composer test
Contributor
Author
There was a problem hiding this comment.
Will add this tomorrow
- use composer script for unittests - align readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use phpunit from vendor to prevent issues
don't suggest to rename
phpunit.xml.disthttps://phpunit.de/manual/current/en/organizing-tests.html#organizing-tests.xml-configuration
If there is no
phpunit.xmlthen phpunit will usephpunit.xml.dist, so whats the point in renaming it?