Added small clarifications for string formatter. #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdurand
approved these changes
Nov 21, 2017
Contributor
Author
|
@willdurand Would you like me to fix the styleci issues given they are not directly related to this PR? |
Member
|
@leevigraham this could be done in a separate PR, WDYT? |
Contributor
Author
|
@willdurand, Makes sense. I'll tackle it tonight. 👍 |
leevigraham
added a commit
to leevigraham/Geocoder
that referenced
this pull request
Nov 22, 2017
As reported: https://styleci.io/analyses/qxKNJB in PR: geocoder-php#798
Merged
Contributor
Author
|
@willdurand StyleCi updated in #799. |
Nyholm
pushed a commit
to geocoder-php/google-maps-provider
that referenced
this pull request
Nov 22, 2017
As reported: https://styleci.io/analyses/qxKNJB in PR: geocoder-php/Geocoder#798
Nyholm
approved these changes
Nov 22, 2017
Nyholm
pushed a commit
to geocoder-php/php-common
that referenced
this pull request
Nov 22, 2017
As reported: https://styleci.io/analyses/qxKNJB in PR: geocoder-php/Geocoder#798
Nyholm
pushed a commit
to geocoder-php/free-geoip-provider
that referenced
this pull request
Nov 22, 2017
As reported: https://styleci.io/analyses/qxKNJB in PR: geocoder-php/Geocoder#798
Nyholm
pushed a commit
to geocoder-php/mapzen-provider
that referenced
this pull request
Nov 22, 2017
As reported: https://styleci.io/analyses/qxKNJB in PR: geocoder-php/Geocoder#798
Nyholm
pushed a commit
to geocoder-php/open-cage-provider
that referenced
this pull request
Nov 22, 2017
As reported: https://styleci.io/analyses/qxKNJB in PR: geocoder-php/Geocoder#798
Nyholm
pushed a commit
to geocoder-php/yandex-provider
that referenced
this pull request
Nov 22, 2017
As reported: https://styleci.io/analyses/qxKNJB in PR: geocoder-php/Geocoder#798
jbelien
pushed a commit
to geocoder-php/google-maps-provider
that referenced
this pull request
Apr 14, 2023
As reported: https://styleci.io/analyses/qxKNJB in PR: geocoder-php/Geocoder#798
jbelien
pushed a commit
to geocoder-php/php-common
that referenced
this pull request
Jul 9, 2023
As reported: https://styleci.io/analyses/qxKNJB in PR: geocoder-php/Geocoder#798
jbelien
pushed a commit
to geocoder-php/free-geoip-provider
that referenced
this pull request
Jul 16, 2023
As reported: https://styleci.io/analyses/qxKNJB in PR: geocoder-php/Geocoder#798
jbelien
pushed a commit
to geocoder-php/open-cage-provider
that referenced
this pull request
Jul 16, 2023
As reported: https://styleci.io/analyses/qxKNJB in PR: geocoder-php/Geocoder#798
jbelien
pushed a commit
to geocoder-php/yandex-provider
that referenced
this pull request
Jul 16, 2023
As reported: https://styleci.io/analyses/qxKNJB in PR: geocoder-php/Geocoder#798
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.