ENH: use attribution from provider if available

[jorisvandenbossche]

Work in progress, still needs to add tests and update docs. And was trying out if I could "auto wrap" the text, but not yet much success (https://matplotlib.org/3.1.1/gallery/text_labels_and_annotations/autowrap.html)

[coveralls]

Coverage increased (+0.2%) to 92.898% when pulling be320b8 on jorisvandenbossche:attribution into 30161bf on darribas:master.

[darribas]

This looks good to me. I'd only say maybe, if we bring in #94 it should be included here too?

[jorisvandenbossche]

I'd only say maybe, if we bring in #94 it should be included here too?

Not fully sure what you mean? We will merge both PRs, and depending on which is merged first, the other will need to fix the conflicts?

[jorisvandenbossche]

It's a little bit unfortunate that we need to do the above in more than one place, but I don't think this is avoidable

[darribas]

Could we maybe turn it into a method that we can use throughout? Something like:

def check_attribution(url, attribution):
    if url is None:
        url = providers.Stamen.Terrain
    if isinstance(url, dict) and attribution is None:
        attribution = url.get("attribution")
    return url, attribution

[jorisvandenbossche]

For now it is only in 2 places. So maybe let's factor out once there is a third ;)

[darribas]

Just very minor changes. The only other thing I'd say it'd be really great to have too is a short notebook demonstrating the providers functionality and how it's embedded in add_basemap, etc.

[darribas]

This is not black compatible?

[jorisvandenbossche]

It's black that did it, so I suppose yes :)

(I think the rule is: if it fits on one line, use one line, if not, put each keyword on its own line)

[darribas]

Could we maybe turn it into a method that we can use throughout? Something like:

def check_attribution(url, attribution):
    if url is None:
        url = providers.Stamen.Terrain
    if isinstance(url, dict) and attribution is None:
        attribution = url.get("attribution")
    return url, attribution

[darribas]

I like this renaming, makes more sense

[jorisvandenbossche]

OK, given the minor comments are somewhat answered, will merge this now