updates example to work with renamed function #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Excellent, thanks for the contribution!!! Glad you're finding the package useful! |
Collaborator
|
Somehow the CI is now failing. I don't think it's related to this patch, but I'll investigate a bit further before merging... |
Contributor
Author
|
Yeah, looks like floating point precision or something like that? The test could be updated to use assert approximately equal. There's support for that in unittest, numpy, and others. |
Collaborator
|
OK I've pushed a couple of updates to the tests (replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
contextily.calculate_zoomwas changed to a private function, so I'm updating the example to work again.BTW, contextily is so nice @darribas :)