Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
oterral
requested changes
Jun 13, 2024
Contributor
oterral
left a comment
There was a problem hiding this comment.
I prefer that you add multiple onXXXClick prop instead of one that you called everywhere.
It will avoid to maage the 2nd parameter which likely is only useful in application, totally useless in react-spatial.
onCloseButttonClick
onLayerButtonClick
onSwitcherButtonClick
onZoomInButtonClick
onZoomOutButtonClick
Contributor
Author
makes sense. Done |
oterral
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to
In WKP we need to track certain events for the SBB, including the BaseLayerSwitcher and Zoom buttons.
A prop was added to trigger a callback function on click of the buttons in the components
Others