Skip to content

Conversation

@tomkralidis
Copy link
Member

Overview

This PR catches cleanup errors, logs the error and emits an ows:ExceptionReport response.

Related Issue / Discussion

#150

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@coveralls
Copy link

coveralls commented Oct 13, 2016

Coverage Status

Coverage decreased (-0.1%) to 76.559% when pulling b382c83 on tomkralidis:issue-150 into be1d094 on geopython:master.

@ldesousa
Copy link
Contributor

Do we want to the process to fail in case PyWPS fails to remove the temp folder? Wouldn't it be better to send back the response and simply log the exception?

@tomkralidis
Copy link
Member Author

Good point @ldesousa. PR updated to only log the error.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 76.571% when pulling 2ab3909 on tomkralidis:issue-150 into be1d094 on geopython:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 76.571% when pulling 2ab3909 on tomkralidis:issue-150 into be1d094 on geopython:master.

@tomkralidis tomkralidis merged commit 45326f7 into geopython:master Oct 14, 2016
@tomkralidis tomkralidis deleted the issue-150 branch October 14, 2016 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants