feat: 🎸 add generators to create community/event/podcast #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for angular-hub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
@geromegrignon I have created the schematics for adding a new community/event/podcast. I tried to identify based on the existing data and the schemas you have made to separate required and non-required props. These are the simplest versions of them (based on me), I am open to your feedback and enhancing them more and more. p.s. Unit Tests are to be added soon. |
Owner
|
Hi @ilirbeqirii, I'll review it tomorrow. |
geromegrignon
requested changes
Jun 28, 2024
plugin/src/generators/create-community/files/src/index.ts.template
Outdated
Show resolved
Hide resolved
plugin/src/generators/create-podcast/files/src/index.ts.template
Outdated
Show resolved
Hide resolved
geromegrignon
requested changes
Jun 29, 2024
Owner
|
Thanks @ilirbeqirii ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: #164
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We are adding comms, events, and podcasts by manually modifying JSON files.
Issue Number: #164
What is the new behavior?
Run the generators to add a new community, event, or podcast.
Does this PR introduce a breaking change?
Other information