feat: add skip to usePreloadedQuery #99
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this discord thread, I've created a minimal demo repo to showcase the DX and UX differences between with/without skip option for
usePreloadedQueryThe primary motivation for this is it would be nice to have an elegant and intuitive api for waiting for auth token to be loaded on client without blocking other parts of the component. With current api, to achieve this you can create another client component and wrap it with
<Authenticated/>, but it becomes tedious in a lot of cases where you do not want to decouple the rendering logic to another component.before:
After:
Closes #98
I am not sure if I missed anything from documentation that can handle this more elegantly, but it is weird to me that you can skip
useQuerybut notusePreloadedQuery.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.