Speed up file indexing #2056
Merged
Speed up file indexing #2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add js.map, yarn.lock to the list of binary file extensions.
kgilpin
requested changes
Oct 8, 2024
Contributor
kgilpin
left a comment
kgilpin
left a comment
There was a problem hiding this comment.
Repetition of words in a document is used by the scoring algorithm. So it’s actually intentional that terms are duplicated in the index. Repeated occurrence of a term boosts the match score.
The number of times that the word appears in the document is part of the BM25 formula.
Instead of using string interpolation, which is always executed, use `debug`'s support for argument formatting, which only evaluates arguments when debugging is enabled. This speeds up FileIndex.indexFile considerably for files with many keywords.
apotterri
force-pushed
the
index-speedups_20241008
branch
from
c96783b to
087d63c
Compare
kgilpin
approved these changes
Oct 9, 2024
Contributor
|
🎉 This PR is included in version @appland/appmap-v3.169.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When indexing files, use
debug's argument formatting facility, rather string interpolation.Also, add
map.jsandyarn.lockto the file extensions being ignored.Fixes #2041 .