bug: hopp_core crashed during call

[iparaskev]

App Version

v0.0.39

Operating system

macOS

Describe the bug

hopp_core crashed during a call. From the logs it seems that screeen sharing got a permanent error and when restarting we got an index out of bounds.

How to reproduce

No idea. Just got it from a sentry event.

Expected behavior

No response

Relevant log output

[2025-09-12][14:19:51][hopp][INFO] [2025-09-12T14:19:51Z INFO  hopp_core::capture::capturer::stream] Capture frame, permanent error

[2025-09-12][14:19:51][hopp][INFO] [2025-09-12T14:19:51Z INFO  hopp_core::capture::capturer] poll_stream: stream failed

[2025-09-12][14:19:51][hopp][INFO] [2025-09-12T14:19:51Z INFO  hopp_core::capture::capturer] restart_stream

[2025-09-12][14:19:52][hopp][INFO] [2025-09-12T14:19:52Z INFO  hopp_core::capture::capturer::stream] get_excluded_application_pids: [67594, 67577]

[2025-09-12][14:19:52][hopp][INFO] [2025-09-12T14:19:52Z INFO  hopp_core::capture::capturer::stream] stream::start_capture: Starting capture for id: 2

[2025-09-12][14:19:52][hopp][INFO] 

[2025-09-12][14:19:52][hopp][INFO] thread '<unnamed>' panicked at src/capture/stream.rs:381:33:

[2025-09-12][14:19:52][hopp][INFO] index out of bounds: the len is 0 but the index is 0

[2025-09-12][14:19:52][hopp][INFO] note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[2025-09-12][14:26:07][hopp][INFO] [2025-09-12T14:26:07Z INFO  hopp_core::input::mouse] set_controller_visible: true

[2025-09-12][14:26:07][hopp][INFO] [2025-09-12T14:26:07Z INFO  hopp_core::room_service] publish_participant_in_control: "PA_o4Gt6jegH9A9"

[2025-09-12][14:26:07][hopp][INFO] [2025-09-12T14:26:07Z INFO  hopp_core::room_service] room_service_commands: Publishing participant in control: "PA_o4Gt6jegH9A9"

[2025-09-12][14:26:14][hopp][INFO] [2025-09-12T14:26:14Z INFO  hopp_core] RenderEventLoop::run Received message: Ping

[2025-09-12][14:26:17][hopp][INFO] [2025-09-12T14:26:17Z INFO  hopp_core::room_service] publish_participant_in_control: "sharer"

[2025-09-12][14:26:17][hopp][INFO] [2025-09-12T14:26:17Z INFO  hopp_core::room_service] room_service_commands: Publishing participant in control: "sharer"

[2025-09-12][14:26:20][hopp][INFO] [2025-09-12T14:26:20Z INFO  hopp_core::input::mouse] set_controller_visible: false

[2025-09-12][14:26:20][hopp][INFO] center_window_on_tray: tray_rect: Rect { position: Physical(PhysicalPosition { x: 2334, y: 0 }), size: Physical(PhysicalSize { width: 68, height: 74 }) }, show_window: true
[2025-09-12][14:26:20][hopp][INFO] center_window_on_tray: Found monitor: Monitor { name: Some("Monitor #41057"), size: PhysicalSize { width: 3024, height: 1964 }, position: PhysicalPosition { x: 0, y: 0 }, work_area: PhysicalRect { position: PhysicalPosition { x: 0, y: 0 }, size: PhysicalSize { width: 3024, height: 1888 } }, scale_factor: 2.0 }
[2025-09-12][14:26:22][hopp][INFO] stop_sharing
[2025-09-12][14:26:22][hopp][INFO] [2025-09-12T14:26:22Z INFO  hopp_core] RenderEventLoop::run Received message: StopScreenshare

[2025-09-12][14:26:22][hopp][INFO] [2025-09-12T14:26:22Z INFO  hopp_core] stop_screenshare

[2025-09-12][14:26:22][hopp][INFO] [2025-09-12T14:26:22Z ERROR hopp_core] stop_screenshare: Error locking screen capturer: PoisonError { .. }

[2025-09-12][14:26:22][hopp::permissions::platform][INFO] macOS accessibility permission check
[2025-09-12][14:26:22][hopp][INFO] get_control_permission: true
[2025-09-12][14:26:22][hopp::permissions::platform][INFO] macOS accessibility permission check
[2025-09-12][14:26:22][hopp][INFO] get_control_permission: true
[2025-09-12][14:26:24][hopp][INFO] stop_sharing
[2025-09-12][14:26:24][hopp][INFO] [2025-09-12T14:26:24Z INFO  hopp_core] RenderEventLoop::run Received message: StopScreenshare

[2025-09-12][14:26:24][hopp][INFO] [2025-09-12T14:26:24Z INFO  hopp_core] stop_screenshare

[2025-09-12][14:26:24][hopp][INFO] [2025-09-12T14:26:24Z ERROR hopp_core] stop_screenshare: Error locking screen capturer: PoisonError { .. }

Attachments

No response

[iparaskev]

This was triggered after screencapturekit failed with a permanent error during capturing. We have observed that these errors are usually temporary and a restart makes them go away, so this is what we do. What happened here is that during the restart the newly initialized capturer was still in error state and returned 0 available sources which made this to be an out of bounds access.

#95 addresses this issue. Note that we allow up to 5 permanent failures in a row before terminating the core process. The PR also makes the error message more descriptive so the user can understand what happened.