Skip to content

feat: node version in docker images #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2024
Merged

feat: node version in docker images #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2135f2e
chore: use node:22-slim as base
amhsirak Dec 11, 2024
08f8684
chore: use BACKEND_PORT
amhsirak Dec 11, 2024
a2b8776
chore: use BACKEND_PORT
amhsirak Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ COPY vite.config.js ./
COPY tsconfig.json ./

# Expose the frontend port
EXPOSE 5173
EXPOSE ${FRONTEND_PORT:-5173}

# Start the frontend using the client script
CMD ["npm", "run", "client", "--", "--host"]
4 changes: 2 additions & 2 deletions server/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/playwright:v1.40.0-jammy
FROM node:22-slim

# Set working directory
WORKDIR /app
Expand Down Expand Up @@ -50,7 +50,7 @@ RUN apt-get update && apt-get install -y \
# RUN chmod +x ./start.sh

# Expose the backend port
EXPOSE 8080
EXPOSE ${BACKEND_PORT:-8080}

# Start the backend using the start script
CMD ["npm", "run", "server"]