fix(maxun-core): button click action during robot execution

[RohitR311]

What this PR does?

Always get the latest fresh button when executing click action during robot execution.

Fixes:
elementHandle.dispatchEvent: Execution context was destroyed, most likely because of a navigation Call log: - waiting for locator(':scope')

Summary by CodeRabbit

• Refactor
  • Improved button interaction handling to enhance stability and reliability in navigation workflows. Internal mechanics were optimized for better consistency across different interaction scenarios.

[coderabbitai]

Walkthrough

Replace direct button element clicks with Playwright locator-based actions using page.locator(workingSelector).first() in maxun-core/src/interpret.ts. Changes affect both primary navigation flows and error-handling fallbacks without altering public API signatures.

Changes

Cohort / File(s)	Summary
Click interaction refactoring maxun-core/src/interpret.ts	Replaced hard-coded button element clicks and dispatch events with Playwright locator-based interactions (page.locator(workingSelector).first().click() and .dispatchEvent('click')). Changes applied across navigation paths, pagination, and error-handling fallbacks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Review the locator selectors used to ensure they match intended button targets
• Verify that .first() correctly handles scenarios where multiple elements match the selector
• Confirm error-handling fallback behavior remains consistent with the new locator-based approach

Possibly related PRs

• fix: skip click action if selector not visible #267: Modifies click-handling logic in the same file, changing how clicks are executed and error-handled with retry/skip-on-invisible behavior.
• fix(maxun-core): run stuck in endless loop of clicking on pagination buttons #876: Updates pagination click loops in the same file to add "no new items" termination logic alongside click handling modifications.

Suggested labels

Type: Bug, Scope: UI/UX

Suggested reviewers

• amhsirak

Poem

🐰 With whiskers twitching, I rejoice,
No more direct clicks—now Playwright's voice!
Locators guide us, selector by name,
Navigation flows, now more tame. 🎯

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately captures the main change: replacing hard-coded button interactions with locator-based actions to fix button click issues during robot execution.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch button-fix

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69ad028 and 288614b.

📒 Files selected for processing (1)

• maxun-core/src/interpret.ts (2 hunks)

🔇 Additional comments (1)

maxun-core/src/interpret.ts (1)

1172-1197: LGTM! Locator-based clicks correctly prevent stale element errors.

The change from button.click() to page.locator(workingSelector).first().click() (and similar for dispatchEvent) is the correct fix for the "Execution context was destroyed" error. Locators re-query elements on each action, avoiding stale ElementHandle references when navigation occurs.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}