Skip to content

fix: match generic modal with theme #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2025
Merged

fix: match generic modal with theme #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7fc9f4
fix: modal bg match theme
amhsirak Nov 15, 2025
6016a61
fix: generic modal bg match theme
amhsirak Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/dashboard/MainMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export const MainMenu = ({ value = 'robots', handleChangeContent }: MainMenuProp
</Box>
</Paper>
<Modal open={sponsorModalOpen} onClose={() => setSponsorModalOpen(false)}>
<Box sx={{ position: 'absolute', top: '50%', left: '50%', transform: 'translate(-50%, -50%)', bgcolor: 'background.paper', borderRadius: 2, p: 4, width: 600 }}>
<Box sx={{ position: 'absolute', top: '50%', left: '50%', transform: 'translate(-50%, -50%)', bgcolor: 'rgba(13, 13, 13, 1)', borderRadius: 2, p: 4, width: 600 }}>
Copy link

@coderabbitai coderabbitai bot Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Hardcoded color breaks theme consistency and creates modal inconsistency.

The sponsor modal now uses a hardcoded dark background while the documentation modal (Line 129) still uses 'background.paper'. This creates:

  • Visual inconsistency between modals in the same component
  • Theme support broken for this modal only
  • Accessibility concerns in light mode

Apply this diff to maintain consistency with the doc modal and theme support:

-        <Box sx={{ position: 'absolute', top: '50%', left: '50%', transform: 'translate(-50%, -50%)', bgcolor: 'rgba(13, 13, 13, 1)', borderRadius: 2, p: 4, width: 600 }}>
+        <Box sx={{ position: 'absolute', top: '50%', left: '50%', transform: 'translate(-50%, -50%)', bgcolor: 'background.paper', borderRadius: 2, p: 4, width: 600 }}>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<Box sx={{ position: 'absolute', top: '50%', left: '50%', transform: 'translate(-50%, -50%)', bgcolor: 'rgba(13, 13, 13, 1)', borderRadius: 2, p: 4, width: 600 }}>
<Box sx={{ position: 'absolute', top: '50%', left: '50%', transform: 'translate(-50%, -50%)', bgcolor: 'background.paper', borderRadius: 2, p: 4, width: 600 }}>
🤖 Prompt for AI Agents 
In src/components/dashboard/MainMenu.tsx around line 168, the sponsor modal Box
uses a hardcoded bgcolor 'rgba(13, 13, 13, 1)' which breaks theme consistency;
replace that hardcoded value with the theme background token (e.g.
'background.paper' or theme.palette.background.paper) so the modal uses the same
themed background as the documentation modal and respects light/dark modes and
accessibility.

<Typography variant="h6" marginBottom={4}>
Support Maxun Open Source
</Typography>
Expand Down
2 changes: 1 addition & 1 deletion src/components/ui/GenericModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const defaultModalStyle = {
left: '50%',
transform: 'translate(-50%, -50%)',
width: 1000,
bgcolor: 'background.paper',
bgcolor: 'rgba(13, 13, 13, 1)',
boxShadow: 24,
p: 4,
height: '50%',
Expand Down