Removed redundant logs from AuditEventSaveTask #5706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
requested changes
Aug 24, 2023
collect_app/src/main/java/org/odk/collect/android/formentry/audit/AuditEventSaveTask.java
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/formentry/audit/AuditEventSaveTask.java
Show resolved
Hide resolved
seadowg
approved these changes
Aug 25, 2023
seadowg
pushed a commit
that referenced
this pull request
Sep 5, 2023
Removed redundant logs from AuditEventSaveTask
This was referenced Oct 3, 2023
This was referenced Oct 18, 2023
Merged
This was referenced Oct 31, 2023
5 tasks
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5703
What has been done to verify that this works as intended?
I've reviewed implemented changes.
Why is this the best possible solution? Were any other approaches considered?
As described in the issue those logs didn't make a lot of sense so it's better to get rid of them.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.