Skip to content

stop using unsupported debug flag for plugins #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VinozzZ merged 1 commit into from
Sep 26, 2022
Merged

stop using unsupported debug flag for plugins #2377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pkg/pkgmgmt/client/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (
"get.porter.sh/porter/pkg/portercontext"
"get.porter.sh/porter/pkg/tracing"
"go.opentelemetry.io/otel/attribute"
"go.uber.org/zap/zapcore"
)

type Runner struct {
Expand Down Expand Up @@ -76,10 +75,6 @@ func (r *Runner) Run(ctx context.Context, commandOpts pkgmgmt.CommandOptions) er
cmd.Args = append(cmd.Args, "-f", commandOpts.File)
}

if span.ShouldLog(zapcore.DebugLevel) {
cmd.Args = append(cmd.Args, "--debug")
}

if commandOpts.Input != "" {
stdin, err := cmd.StdinPipe()
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion pkg/porter/plugins.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func (p *Porter) InstallPlugin(ctx context.Context, opts plugins.InstallOptions)

plugin, err := p.Plugins.GetMetadata(ctx, opts.Name)
if err != nil {
return err
return fmt.Errorf("failed to get plugin metadata: %w", err)
Copy link
Member

@carolynvs carolynvs Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I created #2376 to improve the error message returned when calls to the plugin fail. It would have helped us debug if stderr had been included in the error message that was returned in err.

}

v := plugin.GetVersionInfo()
Expand Down