Allow setting test file with docker test run #2004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meinac
force-pushed
the
make_test_run_configurable
branch
from
50cd347 to
63936ef
Compare
arikfr
reviewed
Oct 9, 2017
Makefile
Outdated
Member
There was a problem hiding this comment.
It can be used to pass any argument/option to nosetsts; maybe we should give it a more generic name, like TEST_ARGUMENTS or something like this?
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback. I think it's a good point, we can rename it as TEST_ARGS or TEST_ARGUMENTS but the variable has to be quoted like;
docker-compose run --rm -e TEST_ARGS="--process=4 tests/handlers/test_dashboards.py" server tests
Passing this argument will override the entire default arguments. The default one will be --with-coverage --cover-package=redash tests/
Does this make sense?
By setting TEST_ARGS environment variable with -e option of docker-compose we can set nosetests options to run the tests as we want, like so; `docker-compose run --rm -e TEST_ARGS="--with-coverage tests/handlers/test_dashboards.py" server tests`
Member
Yes. :) |
meinac
force-pushed
the
make_test_run_configurable
branch
from
63936ef to
b8d2df7
Compare
Contributor
Author
|
Thanks for your quick response, I've updated the makefile as well as the commit message. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the development process, sometimes it makes sense to run only
the related tests of the file you've recently changed for speed.
By this change you can run only one test file, like so;
docker-compose run --rm -e TEST_FILE=tests/handlers/test_dashboards.py server tests