Extract duplicated display-priority label sets and ordering logic into shared module

Consolidated identical hidden-label and low-priority-label sets and their associated priority-ranking functions from snapshot_ui.ts and structured-output-envelope.ts into a new shared module (element-priority.ts). This eliminates duplication risk and ensures atomic updates to label sets across both next-step suggestion ordering and compact JSON target ordering.

Author: cursoragent

src/mcp/tools/ui-automation/shared/element-priority.ts

@@ -0,0 +1,45 @@
+export const HIDDEN_LABELS = new Set(['sheet grabber']);
+
+export const LOW_PRIORITY_LABELS = new Set([
+  'close',
+  'clear search',
+  'remove',
+  'delete',
+  'clear',
+  'c',
+  'ac',
+  '±',
+  '%',
+  '÷',
+  '×',
+  '-',
+  '+',
+  '=',
+]);
+
+export function compactText(value: string | undefined): string {
+  return (value ?? '').replace(/\s+/g, ' ').trim();
+}
+
+export function isHiddenLabel(label: string | undefined): boolean {
+  return HIDDEN_LABELS.has(compactText(label).toLowerCase());
+}
+
+export function isLowPriorityLabel(label: string | undefined): boolean {
+  return LOW_PRIORITY_LABELS.has(compactText(label).toLowerCase());
+}
+
+export function isContentRichElement(element: { label?: string; identifier?: string }): boolean {
+  const label = compactText(element.label);
+  const identifier = compactText(element.identifier);
+  return label.includes(',') || label.length >= 24 || /card$/i.test(identifier);
+}
+
+export function isAlreadySelectedElement(element: {
+  state?: { selected?: boolean };
+  value?: string;
+}): boolean {
+  return (
+    element.state?.selected === true || compactText(element.value).toLowerCase() === 'selected'
+  );
+}

src/mcp/tools/ui-automation/snapshot_ui.ts

@@ -27,6 +27,12 @@ import {
   parseRuntimeSnapshotResponse,
   RuntimeSnapshotParseError,
 } from './shared/runtime-snapshot.ts';
+import {
+  isHiddenLabel,
+  isLowPriorityLabel,
+  isContentRichElement,
+  isAlreadySelectedElement,
+} from './shared/element-priority.ts';
 
 const snapshotUiSchema = z.object({
   simulatorId: z.uuid({ message: 'Invalid Simulator UUID format' }),
@@ -42,69 +48,19 @@ type SnapshotUiResult = CaptureResultDomainResult;
 
 const LOG_PREFIX = '[AXe]';
 
-const HIDDEN_TAP_NEXT_STEP_LABELS = new Set(['sheet grabber']);
-
-const LOW_PRIORITY_TAP_NEXT_STEP_LABELS = new Set([
-  'close',
-  'clear search',
-  'remove',
-  'delete',
-  'clear',
-  'c',
-  'ac',
-  '±',
-  '%',
-  '÷',
-  '×',
-  '-',
-  '+',
-  '=',
-]);
-
-function compactTapNextStepText(value: string | undefined): string {
-  return (value ?? '').replace(/\s+/g, ' ').trim();
-}
-
-function isHiddenTapNextStepElement(label: string | undefined): boolean {
-  return HIDDEN_TAP_NEXT_STEP_LABELS.has(compactTapNextStepText(label).toLowerCase());
-}
-
-function isLowPriorityTapNextStepElement(label: string | undefined): boolean {
-  return LOW_PRIORITY_TAP_NEXT_STEP_LABELS.has(compactTapNextStepText(label).toLowerCase());
-}
-
-function isContentRichTapNextStepElement(element: {
-  label?: string;
-  identifier?: string;
-}): boolean {
-  const label = compactTapNextStepText(element.label);
-  const identifier = compactTapNextStepText(element.identifier);
-  return label.includes(',') || label.length >= 24 || /card$/i.test(identifier);
-}
-
-function isAlreadySelectedTapNextStepElement(element: {
-  state?: { selected?: boolean };
-  value?: string;
-}): boolean {
-  return (
-    element.state?.selected === true ||
-    compactTapNextStepText(element.value).toLowerCase() === 'selected'
-  );
-}
-
 function getTapNextStepElementPriority(element: {
   label?: string;
   identifier?: string;
   state?: { selected?: boolean };
   value?: string;
 }): number {
-  if (isLowPriorityTapNextStepElement(element.label)) {
+  if (isLowPriorityLabel(element.label)) {
     return 90;
   }
-  if (isAlreadySelectedTapNextStepElement(element)) {
+  if (isAlreadySelectedElement(element)) {
     return 70;
   }
-  if (isContentRichTapNextStepElement(element)) {
+  if (isContentRichElement(element)) {
     return 0;
   }
   return 20;
@@ -212,7 +168,7 @@ export async function snapshot_uiLogic(
           ({ element }) =>
             element.actions.includes('tap') &&
             !element.actions.includes('typeText') &&
-            !isHiddenTapNextStepElement(element.label),
+            !isHiddenLabel(element.label),
         )
         .sort((left, right) => {
           const priorityDelta =

src/utils/structured-output-envelope.ts

@@ -6,6 +6,13 @@ import type {
   RuntimeSnapshotUnchangedV1,
   RuntimeSnapshotV1,
 } from '../types/ui-snapshot.ts';
+import {
+  isHiddenLabel,
+  isLowPriorityLabel,
+  isContentRichElement,
+  isAlreadySelectedElement,
+  compactText,
+} from '../mcp/tools/ui-automation/shared/element-priority.ts';
 
 type DomainResultData<TResult extends ToolDomainResult> = Omit<
   TResult,
@@ -38,56 +45,27 @@ type RuntimeSnapshotUnchangedCompactCapture = {
   udid: string;
 };
 
-const HIDDEN_RUNTIME_TARGET_LABELS = new Set(['sheet grabber']);
-
-const LOW_PRIORITY_RUNTIME_TARGET_LABELS = new Set([
-  'sheet grabber',
-  'close',
-  'clear search',
-  'remove',
-  'delete',
-  'clear',
-  'c',
-  'ac',
-  '±',
-  '%',
-  '÷',
-  '×',
-  '-',
-  '+',
-  '=',
-]);
-
 function compactRuntimeSnapshotText(value: string | undefined): string {
-  return (value ?? '').replace(/\s+/g, ' ').replace(/\|/g, '/').trim();
-}
-
-function normalizedRuntimeSnapshotText(value: string | undefined): string {
-  return compactRuntimeSnapshotText(value).toLocaleLowerCase();
+  return compactText(value).replace(/\|/g, '/');
 }
 
 function isHiddenRuntimeTarget(element: RuntimeElementV1): boolean {
-  return HIDDEN_RUNTIME_TARGET_LABELS.has(normalizedRuntimeSnapshotText(element.label));
+  return isHiddenLabel(element.label);
 }
 
 function isLowPriorityRuntimeTarget(element: RuntimeElementV1): boolean {
-  return LOW_PRIORITY_RUNTIME_TARGET_LABELS.has(normalizedRuntimeSnapshotText(element.label));
+  return isLowPriorityLabel(element.label);
 }
 
 function isContentRichTapTarget(element: RuntimeElementV1): boolean {
   if (!element.actions.includes('tap')) {
     return false;
   }
-
-  const label = compactRuntimeSnapshotText(element.label);
-  const identifier = compactRuntimeSnapshotText(element.identifier);
-  return label.includes(',') || label.length >= 24 || /card$/i.test(identifier);
+  return isContentRichElement(element);
 }
 
 function isAlreadySelectedRuntimeTarget(element: RuntimeElementV1): boolean {
-  return (
-    element.state?.selected === true || normalizedRuntimeSnapshotText(element.value) === 'selected'
-  );
+  return isAlreadySelectedElement(element);
 }
 
 function getRuntimeTargetDisplayPriority(element: RuntimeElementV1): number {