feat: Add support for new ignoreMissing and ignoreOptions options #63
Conversation
kamilogorek
changed the title
kamilogorek
force-pushed
the
ignore-options
branch
from
bfea5f8 to
44b85fd
Compare
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
✅ but will leave final approval rights to Ecosystem team.
| |`environment`|Set the environment for this release. E.g. "production" or "staging". Omit to skip adding deploy to release.|-| | ||
| |`finalize`|When false, omit marking the release as finalized and released.|`true`| | ||
| |`ignore_missing`|When the flag is set and the previous release commit was not found in the repository, will create a release with the default commits count instead of failing the command.|`false`| | ||
| |`ignore_empty`|When the flag is set, command will not fail and just exit silently if no new commits for a given release have been found.|`false`| |
There was a problem hiding this comment.
Feels bad to duplicate this between the README and action.yml, but I realized that there are slight differences between the readme and this (for ex, version defaults to {{github.sha}}, but there is not default field in yml for that key).
| default: true | ||
| ignore_missing: | ||
| description: 'When the flag is set and the previous release commit was not found in the repository, will create a release with the default commits count instead of failing the command.' | ||
| required: false |
There was a problem hiding this comment.
ignore_missing and ignore_empty default to false. Do we have to update the action.yml to add a default: true for these fields?
There was a problem hiding this comment.
We don't, as we do that here https://github.com/getsentry/action-release/pull/63/files#diff-4fab5baaca5c14d2de62d8d2fceef376ddddcc8e9509d86cfa5643f51b89ce3dR15-R16
And when not specified in the action.yml, they'll be undefined, thus if (!option) branch will return defaultValue
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
sentry-clito1.67.2stripCommonPrefix,ignoreMissingandignoreOptionsoptionsvalidate.tstooptions.tsas its actually fetching options, not only validating themgetShouldFinalizeto a genericgetBooleanOptionsentry-cliFixes #41
Fixes #59
Fixes #53