Skip to content

Conversation

@sue445
Copy link
Contributor

@sue445 sue445 commented Apr 19, 2022

I am using Self-Hosted Sentry.

README didn't include instructions for creating a release on Self-Hosted Sentry, so I have added them.

ref. https://docs.sentry.io/product/cli/configuration/#configuration-file

Copy link
Member

@leeandher leeandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Requesting a small addition prior to merging though

Comment on lines +79 to +85
- Create a new Sentry release for [Self-Hosted Sentry](https://develop.sentry.dev/self-hosted/)
```yaml
- uses: getsentry/action-release@v1
env:
SENTRY_URL: https://sentry.example.com/
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Do you mind also adding to the 'Environment Variables' section a part that mentions SENTRY_URL? Here's my suggestion, though if you have a clearer way of conveying it, that works too 👍

#### Environment Variables
The following are all _required*_.
|name|description|
|---|---|
|`SENTRY_AUTH_TOKEN`|Authentication token for Sentry. See [installation](#create-a-sentry-internal-integration).|
|`SENTRY_ORG`|The slug of the organization name in Sentry.|
|`SENTRY_PROJECT`|The slug of the project name in Sentry.|
|`SENTRY_URL`*|The URL used to connect to Sentry, defaults to `https://sentry.io`.<br/>(Only required for [Self-Hosted Sentry](https://develop.sentry.dev/self-hosted/))|

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leeandher I have added a description at 1560185. What do you think?

@leeandher leeandher assigned leeandher and unassigned sue445 Apr 21, 2022
Copy link
Member

@leeandher leeandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @sue445! It looks like our CI having issues, I'll make a note for our team to fix that, but totally not a blocker. Thanks again!

@leeandher leeandher merged commit b0cd976 into getsentry:master Apr 21, 2022
@sue445 sue445 deleted the doc_sentry_url branch April 21, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants