fix annotating __init__.py files by stripping __init__ from modpath #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto_type_annotate.py
Outdated
| relative.removesuffix('.py') | ||
| .replace('/', '.') | ||
| .replace('\\', '.') | ||
| .replace(".__init__", "") |
Contributor
There was a problem hiding this comment.
this should be removesuffix -- can you add an additional test demonstrating this mistake as well? (a.__init__somethingelse.b for example)
Contributor
Author
There was a problem hiding this comment.
you're absolutely right. amended with a fix.
karimkhaleel
force-pushed
the
Fix-annotating-__init__.py-files-by-stripping-__init__-from-modpath
branch
2 times, most recently
from
7bc6a48 to
1f690c0
Compare
karimkhaleel
force-pushed
the
Fix-annotating-__init__.py-files-by-stripping-__init__-from-modpath
branch
from
1f690c0 to
229bc90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy doesn't like
__init__in path names.Stripping them out of the modpath gets
__init__.pyfiles to be annotated like other files. Couldn't get it to work for__main__.pyfiles though.