Skip to content

include arroyo_strict_offset_reset in kafka config #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

include arroyo_strict_offset_reset in kafka config #215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e0d827
include arroyo_strict_offset_reset in kafka config
NicoHinderling Jul 23, 2025
9ae98df
update
NicoHinderling Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/launchpad/kafka.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def create_kafka_consumer(
"bootstrap.servers": config["bootstrap_servers"],
"group.id": config["group_id"],
"auto.offset.reset": config["auto_offset_reset"],
"arroyo.strict.offset.reset": config["arroyo_strict_offset_reset"],
"enable.auto.commit": False,
"enable.auto.offset.store": False,
}
Expand Down Expand Up @@ -128,6 +129,9 @@ def get_kafka_config() -> Dict[str, Any]:
if not topics_env:
raise ValueError("KAFKA_TOPICS env var is required")

# Parse arroyo_strict_offset_reset as boolean, default to None if invalid
arroyo_strict_offset_reset = {"true": True, "false": False}.get(os.getenv("ARROYO_STRICT_OFFSET_RESET", "").lower())

# Optional configuration with defaults
return {
"bootstrap_servers": bootstrap_servers,
Expand All @@ -137,4 +141,5 @@ def get_kafka_config() -> Dict[str, Any]:
"max_pending_futures": int(os.getenv("KAFKA_MAX_PENDING_FUTURES", "100")),
"healthcheck_file": os.getenv("KAFKA_HEALTHCHECK_FILE"),
"auto_offset_reset": os.getenv("KAFKA_AUTO_OFFSET_RESET", "latest"), # latest = skip old messages
"arroyo_strict_offset_reset": arroyo_strict_offset_reset,
}