Skip to content

Omit kafka SASL security flags for local dev #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

Omit kafka SASL security flags for local dev #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/launchpad/kafka.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ def create_kafka_consumer(
# Get configuration from environment
config = get_kafka_config()

environment = os.getenv("LAUNCHPAD_ENV")
if not environment:
raise ValueError("LAUNCHPAD_ENV environment variable is required")

# Create Arroyo consumer
# TODO: When we're closer to production, we'll need a way to disable this logic as
# topics, partitions and kafka clusters are configured through getsentry/ops.
Expand All @@ -47,12 +51,19 @@ def create_kafka_consumer(
"arroyo.strict.offset.reset": config["arroyo_strict_offset_reset"],
"enable.auto.commit": False,
"enable.auto.offset.store": False,
"security.protocol": config["security.protocol"],
"sasl.mechanism": config["sasl.mechanism"],
"sasl.username": config["sasl.username"],
"sasl.password": config["sasl.password"],
}

# Only include security fields in non-development environments
if environment != "development":
consumer_config.update(
{
"security.protocol": config["security.protocol"],
"sasl.mechanism": config["sasl.mechanism"],
"sasl.username": config["sasl.username"],
"sasl.password": config["sasl.password"],
}
)

arroyo_consumer = ArroyoKafkaConsumer(consumer_config)

# Create strategy factory
Expand Down
Loading