Skip to content

Conversation

@NicoHinderling
Copy link
Contributor

@NicoHinderling NicoHinderling commented Oct 28, 2025

When debugging why alternative icons are not showing up for Firefox, I realized that some asset catalog images will not have a file path because they are multi-sized assets. I've made a change in the CLI to include them into ParsedAssets still, but we need to ensure that they are parsed with the correct path on launchpad to ensure they are considered and fully analyzed for our image insights

For example, here's one in the firefox app that we weren't actually considering:

    {
        "vector": false,
        "type": 0,
        "imageId": "42D31467-E63B-49D8-8D9B-1B608059E344",
        "size": 236,
        "height": 1024,
        "name": "AppIcon_Alt_Color_Purple",
        "filename": "AppIcon_Alt_Color_Purple",
        "idiom": "phone",
        "width": 1024
    },

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.12%. Comparing base (7e25670) to head (d2501f3).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/launchpad/artifacts/apple/zipped_xcarchive.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   81.01%   81.12%   +0.10%     
==========================================
  Files         156      158       +2     
  Lines       12720    12905     +185     
  Branches     1284     1307      +23     
==========================================
+ Hits        10305    10469     +164     
- Misses       1957     1964       +7     
- Partials      458      472      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

and Path(file_info.path).stem in alternate_icon_names
)
# Some asset catalog entries have no extension, so we include "other" in the OPTIMIZABLE_FORMATS
file_type_match = file_info.file_type.lower() in (self.OPTIMIZABLE_FORMATS | {"other"})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "other" check doesn't seem ideal, is file_type not showing as PNG for these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct. I agree it's not ideal but I think it's ok still because there's the additional check of if stem in alternate_icon_names, which is an array that comes from app_info

@NicoHinderling NicoHinderling merged commit ceb7bed into main Oct 28, 2025
21 checks passed
@NicoHinderling NicoHinderling deleted the ensure-all-asset-catalog-images-are-considered branch October 28, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants