Add msgspec==0.19.0 #1695
Merged
Add msgspec==0.19.0 #1695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srest2021
approved these changes
Oct 14, 2025
joshuarli
approved these changes
Oct 14, 2025
cmanallen
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 15, 2025
…101195) `msgspec` allows us to partially deserialize a JSON payload. By removing the requirement to deserialize full and incremental snapshots, we a significantly increase the performance of the deserialization and significantly reduce the memory consumption. This is particularly important as our consumer suffers from memory usage issue and our single-threaded processing logic is a bottleneck to throughput improvements. Experiments demonstrated a 10x performance uplift and memory usage declined to, essentially, nil. There is a downside. We can no longer read data from incremental snapshots or full snapshots. To do so would require allocating memory and defeat the purpose of this PR. Presently we don't do anything with those events except log some canvas events which, I think, are unimportant enough we can remove them. Full plan: https://www.notion.so/sentry/Q4-25-Recording-Consumer-Improvements-28c8b10e4b5d803cb212e19aebefee81 Related: getsentry/pypi#1695 --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package has no publically disclosed CVEs. Need analysis and implementation plan details: https://www.notion.so/Q4-25-Recording-Consumer-Improvements-28c8b10e4b5d803cb212e19aebefee81