This repository was archived by the owner on Oct 23, 2023. It is now read-only.
fix: Dont serialize nan when present in frame local vars #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
requested review from
dcramer and
mitsuhiko
and removed request for
dcramer
dcramer
reviewed
Dec 17, 2018
dcramer
reviewed
Dec 18, 2018
Member
Author
|
So, every number is a string now. I think this is not necessary for dicts and lists as the trimming behavior is more sophisticated there. We might actually want to port parts of this from raven to the new sdk |
dcramer
approved these changes
Dec 19, 2018
mitsuhiko
approved these changes
Dec 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use Rust on the server to decode JSON and it's not possible to just hook into there and add support for new constants (essentially new syntax) without forking the JSON library or running some code before deserializing.
The exact values are how
frame.varsare coerced on the server anyway so there is no difference in display to the user.Raven still permits sending NaN as part of other variables. Sentry-sdk (in master) treats it like any unserializable value. Serverside this is converted to
Nonewhile deserializing.Not sure if coercing to string would be that great (might create new groups) or if we should rather just crash in the SDK like sentry-sdk does now and drop the event.