This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Allow subclasses of SentryHandler to be modified by the celery logging signal, resolves #961 #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpistrang
changed the title
mpistrang
changed the title
Author
|
Thanks @ashwoods for the approval. Do you need anything else from me for this to be merged? |
Contributor
|
Just wanted to manually rebase it and run the tests again locally. will merge tomorrow morning. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow the celery logging signal to recognize subclasses of
raven.handlers.logging.SentryHandlerwhen searching for existing handlers to add a CeleryFilter to, instead of adding a second handler. This resolves #961