feat(normalization): Trim tag keys & values #5198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been dropping event tag values when they are too long: 7af05d4
SDKs are removing truncation on their side, so Relay should truncate instead of dropping to create the same end-to-end behavior for the product.
Fixes INGEST-538.
Note
Switch handling of overlong tag keys/values from dropping to trimming with remarks, and update tests accordingly.
TrimmingProcessortests, replacing previous behavior that dropped them.normalize::tests::test_too_long_tagsthat expected drop-on-too-long inrelay-event-normalization/src/normalize/mod.rs.trimming::tests::test_too_long_tagsverifying trimmedTagsPairListsnapshots inrelay-event-normalization/src/trimming.rs.PairListwhere needed.Written by Cursor Bugbot for commit 9020285. This will update automatically on new commits. Configure here.