Skip to content

Conversation

@jjbayer
Copy link
Member

@jjbayer jjbayer commented Sep 30, 2025

We've been dropping event tag values when they are too long: 7af05d4

SDKs are removing truncation on their side, so Relay should truncate instead of dropping to create the same end-to-end behavior for the product.

Fixes INGEST-538.


Note

Switch handling of overlong tag keys/values from dropping to trimming with remarks, and update tests accordingly.

  • Tag Trimming Behavior:
    • Implement trimming (with remarks) for overlong tag keys/values in TrimmingProcessor tests, replacing previous behavior that dropped them.
  • Tests:
    • Remove normalize::tests::test_too_long_tags that expected drop-on-too-long in relay-event-normalization/src/normalize/mod.rs.
    • Add trimming::tests::test_too_long_tags verifying trimmed Tags PairList snapshots in relay-event-normalization/src/trimming.rs.
    • Adjust imports to include PairList where needed.

Written by Cursor Bugbot for commit 9020285. This will update automatically on new commits. Configure here.

@linear
Copy link

linear bot commented Sep 30, 2025

@jjbayer jjbayer marked this pull request as ready for review September 30, 2025 13:51
@jjbayer jjbayer requested a review from a team as a code owner September 30, 2025 13:51
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I am missing something, this looks like there were only changes made to tests?

cursor[bot]

This comment was marked as outdated.

@jjbayer jjbayer added this pull request to the merge queue Oct 2, 2025
Merged via the queue into master with commit d181bbb Oct 2, 2025
28 checks passed
@jjbayer jjbayer deleted the feat/truncate-tags branch October 2, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants