feat(tracemetrics): Allow filtering co-occurring keys #5260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
k-fish
force-pushed
the
feat/tracemetrics/add-cooccuring-attribute-names
branch
from
0a11ee5 to
705b19a
Compare
Trace metrics has a blocker of having the available group-by and autocomplete keys being limited to the metric name selected instead of every attribute key ever ingested. Due to how the trace item filter rpc (and eap tables) are currently setup, this is only currently possible with an 'AND' on the key presence, so this is a workaround adding two temporary meta attributes that will let us experiment with this behaviour before open beta.
k-fish
force-pushed
the
feat/tracemetrics/add-cooccuring-attribute-names
branch
from
705b19a to
ebed931
Compare
Dav1dde
reviewed
Oct 16, 2025
Co-authored-by: David Herberth <david.herberth@sentry.io>
Co-authored-by: David Herberth <david.herberth@sentry.io>
Dav1dde
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Trace metrics has a blocker of having the available group-by and autocomplete keys being limited to the metric name selected instead of every attribute key ever ingested. Due to how the trace item filter rpc (and eap tables) are currently setup, this is only currently possible with an 'AND' on the key presence, so this is a workaround adding two temporary meta attributes that will let us experiment with this behaviour before open beta.
more details here