Propagate cfg guards from rust-url #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guard APIs that depend on `Url::to_file_path` and `Url::from_directory_path` on the same platforms as rust-url. This allows to compile rust-sourcemap on other platforms (e.g. wasm32-unknown-unknown) without errors.
Contributor
Author
|
@mitsuhiko The failure doesn't seem relevant - just a Clippy upgrade that should be fixed on master. |
Member
|
This should now be addressed in #20 |
Contributor
Author
|
Yup, thanks, looks like Travis passed now that you merged it. Can someone take a look at this PR too please? |
Contributor
Author
|
Ping @mitsuhiko? |
mitsuhiko
approved these changes
Sep 6, 2019
Contributor
|
Will release. thanks! |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard APIs that depend on
Url::to_file_pathandUrl::from_directory_pathon the same platforms as rust-url.This allows to compile rust-sourcemap on other platforms (e.g.
wasm32-unknown-unknown) without errors.