-
-
Notifications
You must be signed in to change notification settings - Fork 235
ref(upload): Add support for the chunked DIF upload #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The build failures are due to an unreleased symbolic version. |
Just noticed that I'm missing support for |
9b3f0da
to
2e665f8
Compare
@mitsuhiko I will run a symbolic release once the linked PR is merged and merge this once tests pass again. Was thinking about how to test this, but the only way I could come up with was sourcing a test repository with test files. The new upload command and some more refactorings will happen in follow up PRs, this is already large enough. |
@mitsuhiko This is ready for review now. |
This PR adds support for the new chunked upload endpoint refactors the debug information file upload implemented in:
Also, the now-legacy archive dSYM upload is refactored into the same module and fixes some prior issues. All related code is located in the
utils::dif_upload
andapi
modules. The upload follows this general schema:GET /api/chunk-upload
is available. If so, use the provided configuration for chunked uploading, otherwise fall back to the ZIP archive upload. This applies to all commands that previously used thefiles/dsyms
endpoint:upload-dsym
,upload-dbg
andupload-breakpad
__hidden#<num>_
) and resolves them usingdsymutil
if BCSymbolMaps are provided. This replaces the original dSYMs for subsequent steps.struct DsymFile
). The caller can then determine missing dSYMs or apply post processing.This is the list of changes and features included in this PR:
Digest
directly instead of Strings::from_cli
)--require-all
utils::dif_upload
inupload-dsym
utils::upload
module.NOTE: A new unified
upload-sym(s)
command will be added along with some further refactoring in a follow-up PR.