feat: Add dif to assemble response, Add error handling #7207
Conversation
Generated by 🚫 danger |
src/sentry/api/bases/chunk.py
Outdated
| elif len(file_blobs) == len(owned_blobs) == len(chunks) and file is not None: | ||
| return self._create_file_response( | ||
| ChunkFileState.OK | ||
| file.headers.get('__state', ChunkFileState.OK) |
There was a problem hiding this comment.
That could use a constant, maybe
| file=found_file | ||
| ).first() | ||
| if dsym is not None: | ||
| response['dif'] = serialize(dsym) |
There was a problem hiding this comment.
This should even be required if the state is OK and log an error if the ProjectDsymFile is missing since it indicates that something went wrong and we weren't able to write the correct state header.
There was a problem hiding this comment.
We can't check this here, since the original chunked file will be deleted, only the new dsym file is in the database without the __state header at all.
So pretty much the API returns OK if there is no state header but a file with owned blobs.
| def _add_project_dsym_to_reponse(self, found_file, response): | ||
| if found_file is not None: | ||
| if found_file.headers.get('error', None) is not None: | ||
| response['error'] = found_file.headers.get('error') |
There was a problem hiding this comment.
Maybe just a minor consistency thing, but: What if there is an error header but the state is OK? In that case it is weird, that you're adding that field.
There was a problem hiding this comment.
The database doesn't prevent this from happening, but there is no codepath setting OK and error. So when there is an error state is also an error.
|
In regards to your first comment. |
3 participants
No description provided.