-
-
Notifications
You must be signed in to change notification settings - Fork 277
enh: refactor init to use JNI/FFI
#3324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
99 commits
Select commit
Hold shift + click to select a range
e53fa94
Android side
buenaflor 2748859
Update
buenaflor 6033ea8
Update
buenaflor b864cf0
Update
buenaflor cb9f451
Simple ios ffi gen
buenaflor 0f1a611
Fix compilation
buenaflor 23d49da
Update
buenaflor 3e15e01
Update
buenaflor 36491eb
Remove method channel
buenaflor 256ad72
Remove unnecessary code
buenaflor 561d56e
Update
buenaflor 89079ed
Update
buenaflor 1dab36d
Update
buenaflor d7fe123
Update
buenaflor 747c4c3
newlines
buenaflor b8d8378
newlines
buenaflor 9d18550
Update
buenaflor 444175e
Update
buenaflor 7264607
Update
buenaflor 63bb590
Update
buenaflor a968e32
Update
buenaflor 1d807c3
Merge branch 'main' into enh/ffi-jni-init
buenaflor 48fdf3a
Remove macos symlink to SentryFlutter.swift
buenaflor 831e2aa
remove old files
buenaflor 0ae02a4
Newlines
buenaflor 7485ec9
Update
buenaflor ecc5f18
Update
buenaflor 6b5168c
Update
buenaflor a220e61
Ktlint
buenaflor aae15bf
Ktlint
buenaflor 505a2c3
Update
buenaflor e4e447f
Ktlint
buenaflor 7bcea70
Ktlint
buenaflor 3ab4b17
Ktlint
buenaflor 2579aaf
Reuse setSdkMetaData
buenaflor af59e30
Update
buenaflor eb398be
Update
buenaflor 64f2078
remove duplicate typedef capture callback
buenaflor 8892a46
Generate JNI bindings tool
buenaflor b4ca367
Update
buenaflor 9eae5fa
Update
buenaflor ade6888
Optimize JNI bindings size
buenaflor b07b9e4
Update
buenaflor 85cb83f
Update jni binding creation
buenaflor b2a2c33
Swiftlint fix
buenaflor 61b799a
Format
buenaflor 490f204
Fix macos integration tests
buenaflor c2fbcd9
Update
buenaflor 16c8522
Update
buenaflor 0fc6690
Update
buenaflor 60f5d20
Fix android test
buenaflor eb6c5c4
Update
buenaflor 9156fbb
Update
buenaflor 0fb645a
Update
buenaflor 552f14b
Try fix ios integration test
buenaflor b5a2b91
Update
buenaflor fde01d6
Update
buenaflor 231eae8
Fix ios build
buenaflor 41938d4
Fix macos build
buenaflor c88d74d
Update
buenaflor 81dcc72
Fix macos test
buenaflor ea1014d
Updatre
buenaflor 7aedd3e
Update
buenaflor 9774599
Update
buenaflor 2f7cf8a
Allow bigger diffmax
buenaflor ab4c77e
Update swiftlint
buenaflor 1f506d7
Revert JNI generation tool
buenaflor b505363
Update CHANGELOG
buenaflor 39d9557
Update
buenaflor 7dc7d06
Update
buenaflor 63febf4
Remove replay_native test file, it is already tested in integration test
buenaflor 976f8a1
Remove init_native_sdk test, already tested in integration test
buenaflor bbb2cbd
Update coverage
buenaflor 40f9fde
Update coverage
buenaflor 893dc0a
Update coverage
buenaflor 1e73f1b
Fix web integration test
buenaflor 130a676
Update
buenaflor 21cac57
Update
buenaflor 8cc7c05
Disable detekt for now
buenaflor 18fe039
Update
buenaflor 0f928f6
Merge branch 'disable/detekt' into enh/ffi-jni-init
buenaflor ab56b88
Update
buenaflor 48149f1
Update
buenaflor 9808a56
Try fix long running web integration test
buenaflor fd0aa08
Merge branch 'main' into enh/ffi-jni-init
buenaflor 37f0c51
Fix memory leak
buenaflor d31f1a9
Update CI
buenaflor 89fb6c2
Merge branch 'main' into enh/ffi-jni-init
buenaflor 6f4ec41
Update CI
buenaflor 1fa231b
Update CI
buenaflor fd0ba85
Update CI
buenaflor 0a54877
Update CI
buenaflor ef9f743
Update comments
buenaflor 13237cf
Update CI
buenaflor 3807f78
Update CI
buenaflor ead9a05
Update CI
buenaflor 0bb46ef
Update CI
buenaflor f96f0e5
Update CI
buenaflor 1866d6b
Update CI
buenaflor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,4 +13,4 @@ startupTimeTest: | |
|
|
||
| binarySizeTest: | ||
| diffMin: 900 KiB | ||
| diffMax: 1200 KiB | ||
| diffMax: 1300 KiB | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
packages/flutter/android/src/main/kotlin/io/sentry/flutter/ReplayRecorderCallbacks.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package io.sentry.flutter | ||
|
|
||
| interface ReplayRecorderCallbacks { | ||
| fun replayStarted( | ||
| replayId: String, | ||
| replayIsBuffering: Boolean, | ||
| ) | ||
|
|
||
| fun replayResumed() | ||
|
|
||
| fun replayPaused() | ||
|
|
||
| fun replayStopped() | ||
|
|
||
| fun replayReset() | ||
|
|
||
| fun replayConfigChanged( | ||
| width: Int, | ||
| height: Int, | ||
| frameRate: Int, | ||
| ) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.