Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Nov 13, 2025

📜 Description

Similar to how Sentry Android does it: https://github.com/getsentry/sentry-java/blob/main/sentry-android-core/build.gradle.kts#L32C1-L35C4

💡 Motivation and Context

Fixes #3338

💚 How did you test it?

Manually

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.20%. Comparing base (331c3d9) to head (a661a70).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3339      +/-   ##
==========================================
+ Coverage   88.01%   89.20%   +1.18%     
==========================================
  Files         295       99     -196     
  Lines       10122     3408    -6714     
==========================================
- Hits         8909     3040    -5869     
+ Misses       1213      368     -845     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 508.75 ms 508.25 ms -0.50 ms
Size 13.93 MiB 15.06 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3615e19 468.38 ms 504.71 ms 36.33 ms
fd88186 422.07 ms 469.10 ms 47.03 ms
a69a51f 437.18 ms 450.60 ms 13.42 ms
2d34233 470.54 ms 558.90 ms 88.36 ms
7b21e8b 467.74 ms 466.24 ms -1.50 ms
2cf9161 454.12 ms 512.67 ms 58.55 ms
c26ed0a 465.52 ms 476.38 ms 10.86 ms
93b7728 475.28 ms 489.13 ms 13.86 ms
dbd526b 504.88 ms 569.02 ms 64.15 ms
2b5e090 437.21 ms 467.14 ms 29.93 ms

App size

Revision Plain With Sentry Diff
3615e19 6.54 MiB 7.70 MiB 1.16 MiB
fd88186 13.93 MiB 15.00 MiB 1.06 MiB
a69a51f 13.93 MiB 15.06 MiB 1.13 MiB
2d34233 6.54 MiB 7.55 MiB 1.01 MiB
7b21e8b 13.93 MiB 15.00 MiB 1.06 MiB
2cf9161 6.54 MiB 7.70 MiB 1.16 MiB
c26ed0a 13.93 MiB 14.93 MiB 1.00 MiB
93b7728 6.54 MiB 7.69 MiB 1.15 MiB
dbd526b 6.54 MiB 7.69 MiB 1.15 MiB
2b5e090 13.93 MiB 15.06 MiB 1.13 MiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.24 ms 1236.13 ms 4.89 ms
Size 5.53 MiB 6.01 MiB 488.17 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6f47800 1247.52 ms 1259.37 ms 11.85 ms
6bcdc99 1257.16 ms 1264.96 ms 7.79 ms
765aa8b 1259.09 ms 1269.90 ms 10.82 ms
73a3c38 1263.37 ms 1277.90 ms 14.53 ms
0fb45d0 1273.24 ms 1286.44 ms 13.19 ms
aeb02f2 1244.29 ms 1256.55 ms 12.26 ms
f761369 1261.69 ms 1277.82 ms 16.12 ms
0fb3800 1256.60 ms 1266.28 ms 9.68 ms
e04b24b 1230.22 ms 1233.90 ms 3.67 ms
1f639ee 1252.43 ms 1257.82 ms 5.38 ms

App size

Revision Plain With Sentry Diff
6f47800 7.86 MiB 9.44 MiB 1.58 MiB
6bcdc99 5.53 MiB 6.00 MiB 479.95 KiB
765aa8b 7.86 MiB 9.44 MiB 1.58 MiB
73a3c38 7.86 MiB 9.44 MiB 1.58 MiB
0fb45d0 7.86 MiB 9.44 MiB 1.58 MiB
aeb02f2 7.86 MiB 9.44 MiB 1.58 MiB
f761369 7.86 MiB 9.44 MiB 1.58 MiB
0fb3800 7.86 MiB 9.44 MiB 1.58 MiB
e04b24b 5.53 MiB 6.00 MiB 480.00 KiB
1f639ee 5.53 MiB 6.00 MiB 479.95 KiB

buenaflor and others added 4 commits November 13, 2025 11:45
Added `consumerProguardFiles 'proguard-rules.pro'` to the debug build configuration to ensure ProGuard rules are consistently applied across both release and debug variants.
@buenaflor buenaflor merged commit 426fbfd into main Nov 14, 2025
51 of 53 checks passed
@buenaflor buenaflor deleted the fix/proguard-debug-builds branch November 14, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Flutter Android]: Use proguard rules for debug builds as well

3 participants