Fix: EventProcessors were not dropping events when returning null #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
changed the title
marandaneto
commented
Mar 12, 2021
Codecov Report
@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 89.60% 89.79% +0.18%
==========================================
Files 51 51
Lines 1636 1636
==========================================
+ Hits 1466 1469 +3
+ Misses 170 167 -3
Continue to review full report at Codecov.
|
Contributor
|
+1 This is of great significance - otherwise we can never drop any events! When can we see it released? |
Contributor
Author
Monday :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
EventProcessors were not dropping events when returning null
💡 Motivation and Context
Fix #351
💚 How did you test it?
📝 Checklist
🔮 Next steps