Skip to content

Fix: Pass hint to EventProcessors #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2021
Merged

Fix: Pass hint to EventProcessors #356

merged 3 commits into from
Mar 13, 2021

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Mar 13, 2021 •
edited
Loading

📜 Description

Fix: Pass hint to EventProcessors

💡 Motivation and Context

Fix #355

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto requested review from a team and ueman March 13, 2021 15:42
@marandaneto
Copy link
Contributor Author

marandaneto commented Mar 13, 2021

cc @fzyzcjy

marandaneto
marandaneto commented Mar 13, 2021
View reviewed changes
ueman
ueman approved these changes Mar 13, 2021
View reviewed changes
Copy link
Collaborator

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 9c16664 into main Mar 13, 2021
@marandaneto marandaneto deleted the fix/event-processor-hint branch March 13, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

1 more reviewer

@ueman ueman ueman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] (with 1-line-of-code fix) the hint is not passed to processors

3 participants

@marandaneto @ueman