Skip to content

Conversation

@ueman
Copy link
Collaborator

@ueman ueman commented Apr 27, 2021

📜 Description

Run pod lib lint again for iOS and also enable it for macOS.

The trick was to run it with --configuration=Debug as seen here in the Flutter Plugin Repo.

#skip-changelog

💡 Motivation and Context

Closes #348

💚 How did you test it?

CI

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@ueman ueman marked this pull request as ready for review April 27, 2021 06:45
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto
Copy link
Contributor

@ueman damn, thats a good catch, thats why I love open source, we learn and save so much time by reading code :D

@ueman
Copy link
Collaborator Author

ueman commented Apr 27, 2021

@ueman damn, thats a good catch, thats why I love open source, we learn and save so much time by reading code :D

Yeah, one just needs to know where to look for a solution :D

@ueman ueman merged commit 879f737 into main Apr 27, 2021
@ueman ueman deleted the fix/pod-lib-lint branch April 27, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI complains about Flutter valid archies

3 participants