Skip to content

Conversation

@ueman
Copy link
Collaborator

@ueman ueman commented Oct 7, 2021

📜 Description

This change adds the current route as SentryEvent.transaction.

💡 Motivation and Context

https://develop.sentry.dev/sdk/event-payloads/ suggests to use the current route as transaction name.

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.21%. Comparing base (35378c9) to head (058a7f9).
Report is 1563 commits behind head on main.

Files with missing lines Patch % Lines
.../lib/src/navigation/sentry_navigator_observer.dart 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
+ Coverage   90.05%   90.21%   +0.16%     
==========================================
  Files          85       92       +7     
  Lines        2755     3016     +261     
==========================================
+ Hits         2481     2721     +240     
- Misses        274      295      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment other than that, LGTM

@marandaneto marandaneto merged commit d530db2 into getsentry:main Oct 8, 2021
@ueman ueman deleted the feat/transaction-name branch October 8, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants