-
-
Notifications
You must be signed in to change notification settings - Fork 278
Feat: debugPrint integration
#618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: debugPrint integration
#618
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
+ Coverage 90.21% 90.24% +0.02%
==========================================
Files 92 93 +1
Lines 3016 3034 +18
==========================================
+ Hits 2721 2738 +17
- Misses 295 296 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@ueman does that mean that if calling the other question is, the integration lives in the flutter package, but the should we only add this integration by default if |
|
The problem this solves is, that FlutterErrors are collected by the existing FlutterErrorIntegration and then forwarded to the default FlutterError.onError implementation. The default FlutterError.onError implementation calls With this we may still end up with duplication, but it's at least well formatted and it may add breadcrumbs for logs which are done directly with By replacing
No, but
That does make sense. Though as mentioned before I'm not sure we ever want to enable it in debug builds. |
maybe we do both guards then, only add if release build & |
marandaneto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @ueman, looks good, LGTM
📜 Description
This is an integration which intercepts
debugPrintand adds them as breadcrumbs.This fixes #492 by basically removing the call to print done by debugPrint.
💡 Motivation and Context
Fixes #492
💚 How did you test it?
New unit tests
📝 Checklist
🔮 Next steps