Skip to content

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Oct 7, 2024

DESCRIBE YOUR PR

Adds missing code snippets for Nuxt. And excludes Nuxt from "Crons" docs, as we currently have no instrumentation for Nitro Tasks (experimental feature in Nitro).

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline: 10th Oct
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:05am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:05am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 9:05am

@s1gr1d s1gr1d requested review from Lms24, chargome and lforst October 7, 2024 12:18
@codecov
Copy link

codecov bot commented Oct 7, 2024

Bundle Report

Changes will increase total bundle size by 2.45kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.45MB 2.46kB (0.03%) ⬆️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.42MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

….mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@s1gr1d s1gr1d merged commit 683ab67 into master Oct 16, 2024
11 checks passed
@s1gr1d s1gr1d deleted the sig/nuxt-docs-fixes branch October 16, 2024 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants