fix(cloudflare): Improve SvelteKit framework guide code block #11570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
AbhiPrasad
approved these changes
Oct 16, 2024
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Yes the error handler should remain unchanged - thanks for the fix!
Contributor
|
Hi @Lms24, thanks for the update! I noticed that the example code here is for a file that could be a |
Member
Author
|
@coolguyzone the code for JS is identical (minus any type syntax but in this example there's none). I think for the moment, the TS example should suffice and we can spare us the duplication. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the SvelteKit Cloudflare guide code block a bit by
<language> diff)handleErrorhook just to point out that this remains unchanged from the default setup. (@AbhiPrasad Just to sanity-check: It does remain unchanged, right?)