docs(js/react-router): Add setup guide for react router (framework) #12068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 14.47kB (0.07%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
coolguyzone
reviewed
Dec 10, 2024
platform-includes/getting-started-config/javascript.react-router.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
reviewed
Dec 10, 2024
platform-includes/getting-started-config/javascript.react-router.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
reviewed
Dec 10, 2024
platform-includes/getting-started-config/javascript.react-router.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
reviewed
Dec 10, 2024
platform-includes/getting-started-config/javascript.react-router.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
reviewed
Dec 10, 2024
platform-includes/getting-started-sourcemaps/javascript.react-router.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
reviewed
Dec 10, 2024
platform-includes/getting-started-sourcemaps/javascript.react-router.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
reviewed
Dec 10, 2024
coolguyzone
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Thanks for this big update @chargome! 🏄♂️ Looks good from a docs perspective, this is a pretty technical one so we should probably have an engineer review it as well.
…er.mdx Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
…er.mdx Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
…router.mdx Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
…router.mdx Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
andreiborza
reviewed
Dec 12, 2024
platform-includes/getting-started-config/javascript.react-router.mdx
Outdated
Show resolved
Hide resolved
platform-includes/getting-started-config/javascript.react-router.mdx
Outdated
Show resolved
Hide resolved
platform-includes/getting-started-config/javascript.react-router.mdx
Outdated
Show resolved
Hide resolved
platform-includes/getting-started-primer/javascript.react-router.mdx
Outdated
Show resolved
Hide resolved
platform-includes/getting-started-sourcemaps/javascript.react-router.mdx
Outdated
Show resolved
Hide resolved
platform-includes/getting-started-sourcemaps/javascript.react-router.mdx
Outdated
Show resolved
Hide resolved
platform-includes/getting-started-verify/javascript.react-router.mdx
Outdated
Show resolved
Hide resolved
…er.mdx Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
…router.mdx Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
…er.mdx Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
…router.mdx Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
andreiborza
approved these changes
Dec 12, 2024
AbhiPrasad
reviewed
Dec 12, 2024
src/components/platformIcon.tsx
Outdated
| import WindowsSVGLarge from 'platformicons/svg_80x80/windows.svg'; | ||
| import XamarinSVGLarge from 'platformicons/svg_80x80/xamarin.svg'; | ||
| // TODO(cg): move to platformicons once available | ||
| import ReactRouterSVGLarge from 'public/icon/rr.svg'; |
There was a problem hiding this comment.
could we just update platformicons first before merging in this PR? I'd rather avoid this temporary code, and I think these docs can wait the extra 2-3 days.
There was a problem hiding this comment.
sure, I'll ping them again
| Sentry.init({ | ||
| dsn: "___PUBLIC_DSN___", | ||
| integrations: [ | ||
| Sentry.browserTracingIntegration(), |
There was a problem hiding this comment.
shouldn't this use the react router integration?
There was a problem hiding this comment.
No as the routing mechanism is different when using framework mode. If you rely on the routes module then these functions that we need for our "library mode integration" are not exposed
andreiborza
approved these changes
Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds react-router (v7 framework mode) as a new guide within the javascript platform.
Since we do not yet provide a dedicated SDK, these docs just cover a very minimal setup using
@sentry-reactand@sentry/node.closes getsentry/sentry-javascript#14578