Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Feb 5, 2025

DESCRIBE YOUR PR

Adds the migration guide for v9 of the JS SDK.

Resolves getsentry/sentry-javascript#14290

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

@vercel
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 10:49am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 10:49am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 10:49am

@lforst lforst changed the title Add conditionals Add JS v9 migration guide Feb 5, 2025
@lforst lforst requested a review from mydea February 5, 2025 11:52
@codecov
Copy link

codecov bot commented Feb 5, 2025

Bundle Report

Changes will increase total bundle size by 195 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.7MB 201 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.38MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.63MB -0.0%
../instrumentation.js -3 bytes 965.23kB -0.0%
9523.js -3 bytes 941.45kB -0.0%
../app/[[...path]]/page.js.nft.json 70 bytes 376.07kB 0.02%
../app/platform-redirect/page.js.nft.json 70 bytes 375.99kB 0.02%
../app/sitemap.xml/route.js.nft.json 70 bytes 373.96kB 0.02%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 866.04kB -0.0%
static/chunks/9557-*.js -3 bytes 391.11kB -0.0%
static/EFUHGhGjy2CoJJhT9U_FZ/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/EFUHGhGjy2CoJJhT9U_FZ/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/jE8pbJgL59FVTCAsYSVAJ/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/jE8pbJgL59FVTCAsYSVAJ/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this big update 💪 I added a few suggestions, looks good!

@coolguyzone coolguyzone self-assigned this Feb 5, 2025
Luca Forstner and others added 10 commits February 6, 2025 09:41
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
@lforst lforst enabled auto-merge (squash) February 6, 2025 10:44
@lforst lforst merged commit 5201da9 into master Feb 6, 2025
11 checks passed
@lforst lforst deleted the lforst-v9-migration-guide branch February 6, 2025 10:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v9] Finalize v9 Migration guide for docs

3 participants