Skip to content

Conversation

@aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Apr 11, 2025

DESCRIBE YOUR PR

Closes getsentry/self-hosted#2990

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Apr 11, 2025

@aldy505 is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@aldy505
Copy link
Collaborator Author

aldy505 commented Apr 11, 2025

cc @BYK @hubertdeng123 @aminvakil

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only rejecting for that little typo and the clarification of mail.from and SENTRY_MAIL_HOST stuff. Except for those, looks great!

Co-authored-by: Burak Yigit Kaya <ben@byk.im>
@BYK BYK enabled auto-merge (squash) April 15, 2025 15:12
@vercel
Copy link

vercel bot commented Apr 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 3:20pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2025 3:20pm

@BYK BYK merged commit 6fbf666 into getsentry:master Apr 15, 2025
9 of 10 checks passed
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
* docs(self-hosted): detailed email docs regarding best practices

* Update email.mdx

Co-authored-by: Burak Yigit Kaya <ben@byk.im>

---------

Co-authored-by: Burak Yigit Kaya <ben@byk.im>
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document custom email configuration things

2 participants