fix(apple): Update platform titles for Apple OS pages #15015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: phil.niedertscheider <phil.niedertscheider@sentry.io>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
philprime
changed the title
Bundle ReportChanges will decrease total bundle size by 1.21kB (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
ℹ️ *Bundle size includes cached data from a previous commit Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
App Routes Affected:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
This commit updates the Apple platform documentation to improve clarity and consistency across different platforms. It refactors the content to use a more standardized structure and includes updated code examples and feature descriptions. Co-authored-by: phil.niedertscheider <phil.niedertscheider@sentry.io>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…orm-titles-for-apple-os-pages-2bd0
sfanahata
approved these changes
Sep 23, 2025
Contributor
sfanahata
left a comment
sfanahata
left a comment
There was a problem hiding this comment.
@philprime - looks good. I added a missing iOS header for the iOS page (I think it was left out because the root index is built from the new includes file), and added descriptions to each page, which helps with SEO.
philipphofmann
approved these changes
Sep 25, 2025
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
LGTM, with a few comments. Thanks
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
philprime
requested review from
coolguyzone
and removed request for
coolguyzone
Member
Author
|
@sfanahata I changed it so that the common page also uses the includes. To me it looks fine now, please double-check |
philprime
deleted the
cursor/update-platform-titles-for-apple-os-pages-2bd0
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
This PR creates individual
index.mdxfiles for the watchOS, macOS, tvOS, and visionOS platform root pages. Previously, these pages were inheriting from a commonindex.mdxfile, which resulted in all of them incorrectly displaying "iOS" as their title.By adding specific
index.mdxfiles with the correct frontmatter title for each platform, their respective root pages will now display the accurate platform name (e.g., "watchOS" for watchOS). This addresses the issue raised in the Slack thread.IS YOUR CHANGE URGENT?
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES
Slack Thread