-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(otlp): Add python OTLP integration #15093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 2.13kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
a3a3464 to
5f21a72
Compare
279511d to
68ec4fc
Compare
68ec4fc to
ef9e9f7
Compare
|
|
||
| * A [`SpanExporter`](https://opentelemetry.io/docs/concepts/components/#exporters) that will automatically setup the OTLP ingestion endpoint from your Sentry DSN | ||
| * A [`Propagator`](https://opentelemetry.io/docs/concepts/context-propagation/#propagation) that ensures [distributed tracing](/concepts/key-terms/tracing/distributed-tracing/) works | ||
| * Trace/Span linking for all other Sentry events such as Errors, Logs, Crons and Metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to call out that Logs, Crons, and Metrics require additional config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't call that out on this line since this is more like a under-the-hood how it works section titled Behavior
docs/platforms/python/tracing/instrumentation/opentelemetry.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/python/tracing/instrumentation/opentelemetry.mdx
Outdated
Show resolved
Hide resolved
sfanahata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. The only thing I'd love to see changed are the clarifications on only using the OTLP integration for tracing and renaming the POTEL doc + the alert to be clearer.
ef9e9f7 to
480b485
Compare
Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com>
sfanahata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for updating. =]
merge after getsentry/sentry-python#4877 is released
Issues