Skip to content

Fix 404 linter #15312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix 404 linter #15312

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a5539d
change gh action cache logic
a-hariti Oct 24, 2025
8e36b9f
more shortcuts
a-hariti Oct 24, 2025
f774936
reenable step condition checks
a-hariti Oct 24, 2025
24f1ee5
lean up build command
a-hariti Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/lint-404s.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,13 @@ jobs:
${{ github.workspace }}/node_modules
${{ github.workspace }}/.next/cache
${{ github.workspace }}/.eslintcache
key: node-${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
key: node-${{ runner.os }}-${{ steps.setup-node.outputs.node-version }}-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
node-${{ runner.os }}-
node-${{ runner.os }}-${{ steps.setup-node.outputs.node-version }}-
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unconditional Yarn Install Slows CI Builds

The yarn install step now runs unconditionally due to the removal of if: steps.cache.outputs.cache-hit != 'true'. This causes unnecessary dependency installation and slower CI builds, even when node_modules are already restored from cache.

Fix in Cursor Fix in Web


- run: yarn install --frozen-lockfile
if: steps.cache.outputs.cache-hit != 'true'

- run: yarn build
- run: yarn next build
if: steps.filter.outputs.docs == 'true'
env:
SENTRY_DSN: https://examplePublicKey@o0.ingest.sentry.io/0
Expand Down
Loading